use enum for EnableActorBlur, EnablePlayerBlur, EnableIdleScript args #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z64a
reviewed
Jul 29, 2023
ethteck
requested changes
Jul 30, 2023
| @@ -6472,4 +6472,16 @@ enum Language { | |||
| LANGUAGE_ES = 3, | |||
| }; | |||
|
|
|||
| enum IdleScriptState { | |||
There was a problem hiding this comment.
Per the original issue, I think we wanted this one in script_api.h
There was a problem hiding this comment.
I've considered renaming them in the past, but decided against it because the vast, vast majority of calls do not use the RESET/RESTART options (3/117) for EnableActorBlur and (67/1060) for EnableIdleScript. I haven't found any alternative names to be a sufficiently compelling improvement over EnableX for a function which is nearly always used to enable and disable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.