Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More pal work #1102

Merged
merged 18 commits into from
Jul 31, 2023
Merged

More pal work #1102

merged 18 commits into from
Jul 31, 2023

Conversation

ethteck
Copy link
Member

@ethteck ethteck commented Jul 29, 2023

No description provided.

@ethteck ethteck requested a review from bates64 July 29, 2023 14:04
@BowserSlug
Copy link
Collaborator

BowserSlug commented Jul 29, 2023

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀 This PR matches 446 functions (+4.45%) on pal.

src/7fd10_len_b40.c Outdated Show resolved Hide resolved
src/80850_len_3060.c Show resolved Hide resolved
src/80850_len_3060.c Show resolved Hide resolved
tools/splat_ext/pm_sbn.py Show resolved Hide resolved
@@ -2179,6 +2179,483 @@ mgm_01_panel_bowser_img = 0x80243380; // rom:0xE82510
mgm_01_panel_bowser_pal = 0x80243580; // rom:0xE82710
mgm_02_panel_peach_img = 0x80248380; // rom:0xE8AB70
mgm_02_panel_peach_pal = 0x80248580; // rom:0xE8AD70
D_80109710 = 0x801082B0; // rom:0xA13C0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far symbol_addrs.txt has been ordered based on ROM address. Thought I guess that doesn't really matter

src/hud_element.h Show resolved Hide resolved
gPopupMenu->unk_33C = MSG_Menus_006F;
break;
}
msgWidth = get_msg_width(gPopupMenu->unk_330, 0);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out what this code does:
image

It calculates the size of the title textbox by taking (var_s5 - textWidth) * 40%. Afterwards, unk_334 is filled with the x offset of the title text box compares to the rest of the menu.

I don't really understand why var_s5 and var_s6 differ; it causes some titles to be off-center.
image

@ethteck ethteck merged commit 6e80d18 into main Jul 31, 2023
2 checks passed
@ethteck ethteck deleted the pal branch July 31, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants