CUDA: Allow for more thread blocks than the X dimension of the block grid #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes #17 |
pavanbalaji
force-pushed
the
pr/thread-blocks
branch
from
71ac217
to
b473d98
Compare
gcongiu
reviewed
Apr 13, 2020
Even though we use a single dimension right now, we should send all three dimensions to the kernel. This allows us to eventually tune the number of dimensions used. Signed-off-by: Pavan Balaji <[email protected]>
This allows us to handle much larger pack/unpack sizes, and should be sufficient for the forseeable future. Fixes pmodels#17 Signed-off-by: Pavan Balaji <[email protected]>
pavanbalaji
force-pushed
the
pr/thread-blocks
branch
from
b473d98
to
591dc0a
Compare
yfguo
approved these changes
Apr 13, 2020
gcongiu
reviewed
Apr 13, 2020
| *n_threads = THREAD_BLOCK_SIZE; | ||
| uint64_t n_blocks = count * cuda_type->num_elements / THREAD_BLOCK_SIZE; | ||
| n_blocks += ! !(count * cuda_type->num_elements % THREAD_BLOCK_SIZE); | ||
|
|
There was a problem hiding this comment.
For correctness, should this return an error code if the number of blocks exceeds the max allowed size? Or simply assert?
There was a problem hiding this comment.
Oh I think I have commented too late :)
There was a problem hiding this comment.
That would be more than the size of int64_t. At that point, we'd need to change a whole lot of code in yaksa to make it work, and an assert would not be sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR allows us to have as many thread blocks as allowed in all of the three dimensions of the block grid combined.
Expected Impact
This would allow us to pack/unpack larger data sizes than before.
Author Checklist
module: short descriptionand follows good practice