Code

alternate approach for #2907#2919

Code

Draft

dai-shi wants to merge 32 commits intofix-derived-recompute-not-changingpmndrs/jotai:fix-derived-recompute-not-changingfrom fix-derived-recompute-not-changing-2pmndrs/jotai:fix-derived-recompute-not-changing-2Copy head branch name to clipboard

+70-7

Commits

Commits on Jan 6, 2025

• add failing test

  dmaskasky

  committed
  6908f9c

  Copy full SHA for 6908f9c

• a single recomputeDependents in flushBatch

  dmaskasky

  committed
  ade5a39

  Copy full SHA for ade5a39

• centralize finishRecompute

  dmaskasky

  committed
  c985ca8

  Copy full SHA for c985ca8

• cleanup

  dmaskasky

  committed
  ba3075a

  Copy full SHA for ba3075a

• fix test

  dmaskasky

  committed
  3e0e324

  Copy full SHA for 3e0e324

• simplify test

  dmaskasky

  committed
  7a66fd0

  Copy full SHA for 7a66fd0

• remove redundant changedAtoms set

  dmaskasky

  committed
  c6e4d81

  Copy full SHA for c6e4d81

• mark original atom changed

  dmaskasky

  committed
  ea0ed26

  Copy full SHA for ea0ed26

• flushBatch while condition includes dependents size

  dmaskasky

  committed
  3b435d7

  Copy full SHA for 3b435d7

Commits on Jan 7, 2025

• Merge branch 'main' into fix-derived-recompute-not-changing

  dai-shi

  authored
  04734ef

  Copy full SHA for 04734ef

• Merge branch 'main' into fix-derived-recompute-not-changing-2

  dai-shi

  committed
  aecaa09

  Copy full SHA for aecaa09

• recover the test

  dai-shi

  committed
  d8b73b5

  Copy full SHA for d8b73b5

• Merge branch 'fix-derived-recompute-not-changing' into fix-derived-recompute-not-changing-2

  dai-shi

  committed
  ccf0fec

  Copy full SHA for ccf0fec

• Merge branch 'main' into fix-derived-recompute-not-changing-2

  dai-shi

  committed
  8f5a036

  Copy full SHA for 8f5a036

• add failing test

  dmaskasky

  committed
  e5a43d9

  Copy full SHA for e5a43d9

• a single recomputeDependents in flushBatch

  dmaskasky

  committed
  15a1f13

  Copy full SHA for 15a1f13

• centralize finishRecompute

  dmaskasky

  committed
  bbfaee5

  Copy full SHA for bbfaee5

• cleanup

  dmaskasky

  committed
  27ce275

  Copy full SHA for 27ce275

• fix test

  dmaskasky

  committed
  cca2b18

  Copy full SHA for cca2b18

• simplify test

  dmaskasky

  committed
  6a892f5

  Copy full SHA for 6a892f5

• remove redundant changedAtoms set

  dmaskasky

  committed
  c920946

  Copy full SHA for c920946

• mark original atom changed

  dmaskasky

  committed
  048359a

  Copy full SHA for 048359a

• flushBatch while condition includes dependents size

  dmaskasky

  committed
  ba84b18

  Copy full SHA for ba84b18

• refactor: move flushBatch in buildStore and call recomputeDependents directly

  dmaskasky

  committed
  a488c0a

  Copy full SHA for a488c0a

• Merge commit 'e5a43d98219367f02291f4dd64ba94566135a440' into fix-derived-recompute-not-changing-2

  dai-shi

  committed
  8347d62

  Copy full SHA for 8347d62

• remove log

  dai-shi

  committed
  ef52454

  Copy full SHA for ef52454

• Merge branch 'main' into fix-derived-recompute-not-changing-2

  dai-shi

  committed
  113f4bc

  Copy full SHA for 113f4bc

• Merge branch 'main' into fix-derived-recompute-not-changing

  dai-shi

  authored
  0245b72

  Copy full SHA for 0245b72

• Merge branch 'fix-derived-recompute-not-changing' into fix-derived-recompute-not-changing-2

  dai-shi

  committed
  13f159e

  Copy full SHA for 13f159e

• use map for batch

  dai-shi

  committed
  5c503d3

  Copy full SHA for 5c503d3

• make dirty flag a number

  dai-shi

  committed
  c08c09c

  Copy full SHA for c08c09c

• Revert "use map for batch"

  Show description for 628f569
  dai-shi

  committed
  628f569

  Copy full SHA for 628f569