Wind Charge Implementation #6427

CJMustard1452 · 2024-08-16T05:23:48Z

Introduction

Implementation for the 1.21.0 Wind Charge

Relevant issues

N/A

Details

Non-iron doors and trapdoors are flipped.
Fence gates are flipped.
Buttons are pressed.
Levers are flipped.
Bells are rung and swung.
Chorus flowers and pointed dripstone blocks break, dropping in item form.
Lit candles (both standalone and on cake) are extinguished.

Wind charges can be deflected if hit with another projectile or a melee attack, similar to ghast fireballs.
Wind charges are distance attenuated by liquids such as water and lava. They also appear to fly in a straight line, similar to fireballs
Wind charges are set to despawn after five minuets due to the gravity less nature of the entity.

https://minecraft.wiki/w/Wind_Charge

Changes

One method has been added to pocketmine\block\Block:

	/**
	 * Called when this block is updated by a state altering projectile in the world.
	 *
	 * @param pocketmine\entity\projectile\Projectile $projectile The projectile affecting the block.
	 */
	public function onProjectileInteraction(pocketmine\entity\projectile\Projectile $projectile) : void {

	}

Both class' for the Wind Charge item and Projectile have been created:

pocketmine\entity\projectile\WindCharge.php
pocketmine\item\WindCharge.php

One class has been created to handle the wind charge explode particle:

pocketmine\world\particle\WindExplosionParticle.php

One class has been added to handle wind charge burst sound:

pocketmine/world/sound/WindChargeBurstSound.php

The Wind Charge has been implemented as a vanilla item.
The Wind Charge Entity has been implemented as an Entity.

API changes

N/A

Behavioural changes

N/A

Backwards compatibility

N/A

Follow-up

N/A

Tests

I tested this PR by doing the following (tick all that apply):

Writing PHPUnit tests (commit these in the tests/phpunit folder)
Playtesting using a Minecraft client (provide screenshots or a video)
Writing a test plugin (provide the code and sample output)
Other (provide details)

Behavior With Other Blocks

Behavior.mp4

Behavior With Players (shows less effective under water.)

minecraft-2024-06-26-02-45-54-online-video-cuttercom-1_T9Woq9fd.mp4

Behavior Multi Hit

Minecraft.2024-06-26.03-18-39.mp4

CJMustard1452

Newly re-based PR...

dadodasyra

Except this it looks good to me, I don't understand why does Github web preview looks like indentation is off but it seems not to.

src/world/sound/WindChargeBurstSound.php

src/block/ChorusFlower.php

src/entity/projectile/WindCharge.php

src/item/WindCharge.php

src/block/Candle.php

ipad54 · 2024-08-17T12:22:12Z

It's seems like fall distance compensation is missing.

In vanilla, a player launched by wind charges shot by a player accumulates fall damage only when falling below the Y level where the wind burst hit.

src/block/Candle.php

src/block/CakeWithCandle.php

ShockedPlot7560 · 2024-08-19T07:02:29Z

src/block/Button.php

@@ -91,4 +89,19 @@ public function onNearbyBlockChange() : void{
 	private function canBeSupportedAt(Block $block, int $face) : bool{
 		return $block->getAdjacentSupportType(Facing::opposite($face))->hasCenterSupport();
 	}
+
+	public function onProjectileInteraction(Projectile $projectile) : void{
+		if($projectile instanceof WindCharge) {


need to check if its not pressed

$this->pressed(); in this context, thereby extending the pushed duration if already down, I do not see a need to change this, thoughts?

by checking that it is not activated, you will avoid extra sound.

ShockedPlot7560 · 2024-08-19T07:04:49Z

src/block/Door.php

+			// This is to avoid calling Door::onProjectileInteraction() twice due to two tiles.
+			if($this->top) {


So, if the projectile hit the upper one, no toggle will be happened ?

Yeah, this is my best attempt at handling this issue, if it hits both blocks the door hits, (open, close)

Can be useful before toggling to check the other state. If its not the same as ours when projectile hits, we can ignore ? Just a theory

feels a little hacky to be honest

Maybe hacky but can avoid to have unexpected side effect if only the top block is hitten by the effect area.

Yep, only checking the one half will cause bugs. It's the same as if a player were clicking the top or bottom half, so the logic should be basically the same.

ShockedPlot7560 · 2024-08-19T07:07:43Z

src/block/Trapdoor.php

+			if($this->getTypeId() === BlockTypeIds::IRON_TRAPDOOR) {
+				return;
+			}


Would be better to moove it into the condition above?

ShockedPlot7560 · 2024-08-19T07:10:06Z

An additional comment: isn't it better to check whether it's a windcharge by the typeId rather than the instance?

dktapps · 2024-11-26T12:08:46Z

src/block/Trapdoor.php

+	}
+
+	public function onProjectileInteraction(Projectile $projectile) : void{
+		if($projectile instanceof WindCharge && $this->getTypeId() !== BlockTypeIds::IRON_TRAPDOOR){


Not liking the iron trapdoor check hardcoded in here.

dktapps · 2024-11-26T12:09:56Z

src/block/Trapdoor.php

+		}
+	}
+
+	public function toggle() : void {


This should be private or protected, making it public has implications beyond this PR's scope

dktapps · 2024-11-26T12:10:03Z

src/block/Lever.php

+		}
+	}
+
+	public function toggle() : void {


This should be private or protected, making it public has implications beyond this PR's scope

dktapps · 2024-11-26T12:10:12Z

src/block/Door.php

+		}
+	}
+
+	public function toggle() : void {


This should be private or protected, making it public has implications beyond this PR's scope

dktapps · 2024-11-26T12:10:28Z

src/block/Door.php

+
+	public function onProjectileInteraction(Projectile $projectile) : void{
+		if($projectile instanceof WindCharge) {
+			if($this->getTypeId() === BlockTypeIds::IRON_DOOR) {


Not liking this check, same as before with trapdoors

dktapps · 2024-11-26T12:11:17Z

src/block/Button.php

+		}
+	}
+
+	public function press() : void {


This should be private or protected, making it public has implications beyond this PR's scope

dktapps · 2024-11-26T12:14:58Z

src/block/Block.php

@@ -513,6 +513,15 @@ public function onScheduledUpdate() : void{

 	}

+	/**
+	 * Called when this block is updated by a state altering projectile in the world.


This sentence doesn't mean anything to me. It doesn't tell me why an update was triggered, nor what kind of state alterations should take place.

The function is trying to look and sound generic, but it's not.
"interaction" is also too vague.

github-actions · 2024-12-06T02:05:50Z

This PR has been marked as "Waiting on Author", but we haven't seen any activity in 7 days.

If there is no further activity, it will be closed in 28 days.

Note for maintainers: Adding an assignee to the PR will prevent it from being marked as stale.

CJMustard1452 added 2 commits August 16, 2024 00:22

feat: implmented wind charges

f828749

fix: submodule nonsence

4f3fc20

CJMustard1452 commented Aug 16, 2024

View reviewed changes

dadodasyra reviewed Aug 16, 2024

View reviewed changes

src/world/sound/WindChargeBurstSound.php Show resolved Hide resolved

ipad54 reviewed Aug 16, 2024

View reviewed changes

src/block/ChorusFlower.php Outdated Show resolved Hide resolved

src/entity/projectile/WindCharge.php Outdated Show resolved Hide resolved

src/item/WindCharge.php Outdated Show resolved Hide resolved

src/block/Candle.php Outdated Show resolved Hide resolved

CJMustard1452 added 2 commits August 16, 2024 16:56

feat: edit to ipad54 reveiw

54caeb4

fix: chours flower issue

d1e5f8c

CJMustard1452 added 2 commits August 18, 2024 23:27

Merge branch 'minor-next' into Wind-Charge

0002323

tweek: edit $impact value to simulate vanilla mechs

3b16dd7

ShockedPlot7560 reviewed Aug 19, 2024

View reviewed changes

ShockedPlot7560 added Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Aug 19, 2024

CJMustard1452 added 3 commits August 19, 2024 17:23

Merge branch 'minor-next' into Wind-Charge

4a2c6cc

tweak: edit to some ShockedPlot7560 comments

10ac730

fix: trapdoor.php visual edit

7117617

dktapps requested changes Nov 26, 2024

View reviewed changes

dktapps added the Status: Waiting on Author label Nov 26, 2024

github-actions bot added the Stale label Dec 6, 2024

dktapps self-assigned this Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wind Charge Implementation #6427

Wind Charge Implementation #6427

CJMustard1452 commented Aug 16, 2024

CJMustard1452 left a comment

dadodasyra left a comment

ipad54 commented Aug 17, 2024

ShockedPlot7560 Aug 19, 2024

CJMustard1452 Aug 19, 2024

ShockedPlot7560 Aug 22, 2024

ShockedPlot7560 Aug 19, 2024

CJMustard1452 Aug 19, 2024

ShockedPlot7560 Aug 19, 2024

CJMustard1452 Aug 19, 2024

ShockedPlot7560 Aug 22, 2024

dktapps Nov 26, 2024

ShockedPlot7560 Aug 19, 2024

ShockedPlot7560 commented Aug 19, 2024

dktapps Nov 26, 2024

dktapps Nov 26, 2024

dktapps Nov 26, 2024

dktapps Nov 26, 2024

dktapps Nov 26, 2024

dktapps Nov 26, 2024

dktapps Nov 26, 2024

github-actions bot commented Dec 6, 2024

		// This is to avoid calling Door::onProjectileInteraction() twice due to two tiles.
		if($this->top) {

Wind Charge Implementation #6427

Are you sure you want to change the base?

Wind Charge Implementation #6427

Conversation

CJMustard1452 commented Aug 16, 2024

Introduction

Relevant issues

Details

Changes

API changes

Behavioural changes

Backwards compatibility

Follow-up

Tests

Behavior With Other Blocks

Behavior With Players (shows less effective under water.)

Behavior Multi Hit

CJMustard1452 left a comment

Choose a reason for hiding this comment

dadodasyra left a comment

Choose a reason for hiding this comment

ipad54 commented Aug 17, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShockedPlot7560 commented Aug 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 6, 2024