-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Facing and Axis to enum #91
Conversation
If we're going with enums I would prefer to ditch the numeric values entirely. They have no purpose except to be implicitly misused as Minecraft constants. |
Should I do the same for Axis? I don't know if these values represent anything or not |
Yes |
This pr is good ? if yes i can change pocketmine to support Facing enum |
I was going to submit these as review comments, but it's less effort if i just fix them directly
Fix #89
This change requires many changes in pmmp. I can do if this pr is good for you.