Vector3 is now immutable #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This requires a PHP 8.2 minimum |
Yes but pocketmine now support PHP 8.2 |
|
Supporting 8.2 != minimum 8.2 |
When pocketmine will oblige PHP 8.2? |
|
Not before PM6. |
dktapps
requested changes
Dec 2, 2024
|
may be add in this pr immutable for Vector2, AABB... because the changes of this pr is light |
|
No. Making a PR 101: Do not do multiple changes at once. |
|
ok |
|
You need to drop PHP 8.1 from composer.json and GitHub Actions |
|
Like this ? |
|
Yep |
dktapps
previously approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete #88 just for Vector3