-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed server freezing vulnerabiity in multiple packets #245
base: master
Are you sure you want to change the base?
Conversation
The issue is that these are arbitrary values. Ideally, Mojang themselves would put maximum values on these. |
what do you suggest then? i'm often seeing servers affected by attack |
what if we just increase all of them to 500 or 1000? |
In the absence of a maximum value defined by mojang, we can't set a maximum value ourselves. |
maybe you can attempt to discuss that with them? i'm basically freezing server simply by sending million entries in textpacket |
In the future, please send vulnerability patches to us privately via [email protected] instead of a public pull request. |
imagine thinking that'd work |
whole purpose of mojang is to "improve security" and that would be really bad of them to refuse to fix vulnerability that affects BDS |
they've known about it for years already |
My suggestion is to set the value high enough so that there can be no problems, but low enough to avoid this kind of attack, and I would like to point out that you have forgotten a huge number of packets @Gewinum |
no point in going on with the PR, they say mojang has no limit so pm wont have too. the best choice is to limit via proxy. as for other packets, i wanted to check if i could fix annoying textpacket vulnerability first, cause its the most op |
There is even plugin called AntiBadPackets about it, but I think some of these vulns are better to be handled here