-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor for Dataflow runner #3
Conversation
07eac77
to
6a61067
Compare
2c4458d
to
d41657d
Compare
5f516ff
to
a45f8b6
Compare
4886b5d
to
0d3967f
Compare
06ca412
to
76f6335
Compare
76f6335
to
6cc2c8c
Compare
Images for When PRs get merged to main, we then also release a public version of the images to Docker Hub. These are found under:
These public releases make running the pipeline easier for developers who just want to use this tool without having to rebuild things. A Cloud Run can easily be spun up with the model server image. Then the pipeline can be run with a direct runner using the pipeline worker image on a Direct Runner. If |
The changes in this PR start prepping the pipeline to be runnable on a Dataflow Runner, though is currently incomplete (as of 07eac77).
Work on this is currently paused, in order to complete the full pipeline (PR #2 for classifier w/ model-aaS, a post-processing stage #4, and standardized writing to local and cloud #20). I'll pick this Dataflow runner PR up again once those are complete.
Things to implement:
Unit tests to build imagesKeep dependencies to minimum in GHA (avoidssudo apt-get install libhdf5-dev libsndfile1
)Terraform IaC elements?add in a separate PR later