run_qemu.sh: do not look for unused OVMF binaries on --legacy-bios #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to test pure build issues. Signed-off-by: Marc Herbert <[email protected]>
This is a correction of previous commit 8504b01 ("run_qemu.sh: move get_ovmf_binaries() later, to start_qemu()") This is not so much about --legacy-bios but rather to regroup all OVMF-related stuff in a single place and makes it easier to temporarily disable OVMF locally. For instance: when using --direct-kernel which is the default. And yes: the image can boot with --direct-kernel and no OVMF at all. Whether that's a good idea or not is a different question - but it's sometimes useful as a local test hack. Signed-off-by: Marc Herbert <[email protected]>
stellarhopper
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 commits