run_qemu.sh: use set -x to always log the qemu command
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the most complex and most important command: the name of this whole git repo is "run_qemu"! This leaves a failing qemu command visible on the terminal. When the qemu command does not fail, it's drown by all the other messages and barely visible in the logs. Signed-off-by: Marc Herbert <[email protected]>
|
Hm so I agree with printing the cmdline in the --debug case, but since we already have a --cmdline option to pretty print the command line here: https://github.com/pmem/run_qemu/blob/main/run_qemu.sh#L1607 , would it be better to refactor the bits to pretty print it into a function, and then call it and exit in the --cmdline case, and just call it in the --debug case before running it? |
Sorry I missed that. Let me think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the most complex and most important command: the name of this whole git repo is "run_qemu"!
This leaves a failing qemu command visible on the terminal.
When the qemu command does not fail, it's drown by all the other messages and barely visible in the logs.