Skip to content
This repository was archived by the owner on Mar 22, 2023. It is now read-only.

fuse: bug fixes #438

Merged
merged 6 commits into from
Nov 8, 2017
Merged

fuse: bug fixes #438

merged 6 commits into from
Nov 8, 2017

Conversation

mslusarz
Copy link
Contributor

@mslusarz mslusarz commented Nov 3, 2017

Part of #437 that passes tests.


This change is Reviewable

Running in foreground is not always desirable.
allow_others option requires more privileges.
readlink hook semantics are different from sys_readlink
"create" hook doesn't have sys_creat semantics.
When user passed O_CREAT | O_RDWR as flags to open, we created write-only
file handle...
@codecov
Copy link

codecov bot commented Nov 3, 2017

Codecov Report

Merging #438 into master will decrease coverage by 0.51%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage    79.4%   78.88%   -0.52%     
==========================================
  Files          71       71              
  Lines        8749     8809      +60     
  Branches     1769     1774       +5     
==========================================
+ Hits         6947     6949       +2     
- Misses       1352     1412      +60     
+ Partials      450      448       -2
Flag Coverage Δ
#ltp_tests 45.74% <ø> (ø) ⬆️
#sqlite_tests 45.67% <ø> (ø) ⬆️
#tests_antool 15.06% <0%> (-0.11%) ⬇️
#tests_posix_multi_threaded 25.35% <0%> (-0.1%) ⬇️
#tests_posix_single_threaded 57% <0%> (-0.47%) ⬇️
#tests_preload 44.74% <0%> (-0.3%) ⬇️
Impacted Files Coverage Δ
src/pmemfile-fuse/main.c 0% <0%> (ø) ⬆️
src/libpmemfile-posix/rename.c 90.68% <0%> (-0.41%) ⬇️
src/libpmemfile-posix/dir.c 90.44% <0%> (+0.24%) ⬆️
src/libpmemfile-posix/inode.c 89.07% <0%> (+0.33%) ⬆️
src/libpmemfile-posix/data.c 94.88% <0%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8856a63...fd1280b. Read the comment docs.

@krzycz
Copy link
Contributor

krzycz commented Nov 3, 2017

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.


Comments from Reviewable

@marcinslusarz marcinslusarz merged commit fbb67ef into pmem:master Nov 8, 2017
@mslusarz mslusarz deleted the just-fixes branch November 8, 2017 19:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants