Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sub pages (for stream and miniasync) #260

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

lukaszstolarczuk
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk commented Jul 1, 2022

Preview:


This change is Reviewable

at least 2 links from #200 are updated by this PR :)

Copy link
Contributor

@kilobyte kilobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 4 unresolved discussions (waiting on @kilobyte and @lukaszstolarczuk)


data/en/miniasync.yml line 60 at r1 (raw file):

            content: "N/A"
          col4:
            content: "Full, in development"

I don't believe the release is supposed to have full support. With the software in flux, I don't expect you to look for bug fixes that could be backported to the release.

Let's reword the status?


data/en/miniasync.yml line 61 at r1 (raw file):

          col4:
            content: "Full, in development"
  possible_statuses_list:

The list of statuses is longer than the whole rest of the content, and it doesn't seem to apply yet. Perhaps we should comment it out for now?


data/en/pmemstream.yml line 70 at r1 (raw file):

            content: "0.2.0 (Jun 28, 2022)"
          col4:
            content: "Full, in development"

.


data/en/pmemstream.yml line 71 at r1 (raw file):

          col4:
            content: "Full, in development"
  possible_statuses_list:

.

Copy link
Member Author

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 14 files reviewed, 4 unresolved discussions (waiting on @kilobyte)


data/en/miniasync.yml line 60 at r1 (raw file):

Previously, kilobyte (Adam Borowski) wrote…

I don't believe the release is supposed to have full support. With the software in flux, I don't expect you to look for bug fixes that could be backported to the release.

Let's reword the status?

I disabled this section for now, since I agree it makes a little sense to inform about maintenance status - we state "This is still an experimental, pre-release software." on the very top of the page, that should be enough.


data/en/miniasync.yml line 61 at r1 (raw file):

Previously, kilobyte (Adam Borowski) wrote…

The list of statuses is longer than the whole rest of the content, and it doesn't seem to apply yet. Perhaps we should comment it out for now?

Done.


data/en/pmemstream.yml line 70 at r1 (raw file):

Previously, kilobyte (Adam Borowski) wrote…

.

Done.


data/en/pmemstream.yml line 71 at r1 (raw file):

Previously, kilobyte (Adam Borowski) wrote…

.

Done.

Copy link
Member

@pbalcer pbalcer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 14 files at r1, 2 of 4 files at r2, all commit messages.
Reviewable status: 10 of 14 files reviewed, 4 unresolved discussions (waiting on @kilobyte and @pbalcer)

@pbalcer pbalcer merged commit c3fd34b into pmem:main Jul 6, 2022
@lukaszstolarczuk lukaszstolarczuk deleted the add-new-sub-pages branch July 6, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants