Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link fixes #238

Merged
merged 21 commits into from
May 12, 2022
Merged

Link fixes #238

merged 21 commits into from
May 12, 2022

Conversation

kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented May 12, 2022

Fixes were made based on the logs from #200.


This change is Reviewable

kswiecicki added 21 commits May 11, 2022 15:56
There are no manpages for pmempool v1.0 and v.1.1 stored in the
pmem.github.io contents. For this reason links to those versions
were removed.

pmempool-sync link was fixed.
Linked vector class is no longer experimental on 'master' branch,
for this reason link to the vector in this article returns 404.
cpp-vector.md article says that the vector was added recently.
The link to libpmemobj-cpp vector class was changed from 'master'
to the earliest available version of the lib with vector marked
as experimental.
Linked classes are no longer experimental on 'master' branch,
for this reason links in the current article return 404.
cpp-array.md article mentions 1.5 release.
The links to libpmemobj-cpp classes were changed from 'master'
to the v1.5 version of the lib.
When there is an empty line in code snippet the rest of the
snippet content is displayed incorrectly.
File name is too big to be mentioned in the commit message.
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 51 of 51 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @kswiecicki)


content/blog/2018/cpp-array.md line 192 at r1 (raw file):

so you can expect our containers collection to grow in the near future.

[cpp_array]: /libpmemobj-cpp/v1.5/doxygen/structpmem_1_1obj_1_1experimental_1_1array.html 'pmem::obj::array'

I think we should rather use https://pmem.io/libpmemobj-cpp/master/doxygen/structpmem_1_1obj_1_1array.html master docs (array is no longer experimental, that's why it was broken)

applies to all below


content/blog/2018/release-1-5.md line 249 at r1 (raw file):

We started the containers work easy, with `pmem::obj::array` that provides some
convenience features for use with transactions. See our
[doxygen](/libpmemobj-cpp/v1.5/doxygen/structpmem_1_1obj_1_1experimental_1_1array.html) documentation for more info.

.

https://pmem.io/libpmemobj-cpp/master/doxygen/structpmem_1_1obj_1_1array.html


content/blog/2019/cpp-vector.md line 295 at r1 (raw file):

[cpp_containers]: /blog/2018/11/c-persistent-containers/ 'blog post'
[cpp_vector]: /libpmemobj-cpp/v1.6/doxygen/classpmem_1_1obj_1_1experimental_1_1vector.html 'pmem::obj:experimental:vector'

.

https://pmem.io/libpmemobj-cpp/master/doxygen/classpmem_1_1obj_1_1vector.html

@pbalcer pbalcer merged commit 0ab662c into pmem:main May 12, 2022
@pbalcer
Copy link
Member

pbalcer commented May 12, 2022

I merged without looking, sorry ;) please address Lukasz's comments in a separate PR. Thanks.

@kswiecicki
Copy link
Contributor Author

I merged without looking, sorry ;) please address Lukasz's comments in a separate PR. Thanks.

Sure, @lukaszstolarczuk I've addressed your remarks here: #239.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants