prov/sharp: Implement sharp_domain2() using sharp_coll API

[ldorau]

Depends on:

• prov/sharp scaffolding #8

---

This change is 

[grom72]

Reviewed 20 of 26 files at r1, 1 of 2 files at r2, 1 of 2 files at r3, 2 of 3 files at r4, all commit messages.
Reviewable status: 23 of 27 files reviewed, 3 unresolved discussions (waiting on @ldorau)

---

prov/sharp/src/sharp_domain.c line 264 at r3 (raw file):

err_free_domain:
	free(domain);
	return ret;

Return value to be converted to libfabric specific error code FI_E...

Code quote:

ret

---

prov/sharp/src/sharp_domain.c line 233 at r4 (raw file):

	struct sharp_coll_config config = { /* XXX */
/* ??? */	.ib_dev_list = NULL,		/**< IB device name, port list. (const char *) */
/* ??? */	.user_progress_num_polls = 0,	/**< Number of polls to do before calling user progress. (int) */

Suggestion:

.user_progress_num_polls = -1

---

prov/sharp/src/sharp_domain.c line 247 at r4 (raw file):

		.world_local_rank = 0,			/**< relative rank of this process on this node within its job. */
/* ??? */	.enable_thread_support = 0,		/**< enable multi threaded support. */
/* ??? */	.oob_ctx = context,			/**< context for OOB functions in sharp_coll_init */

Suggestion:

.oob_ctx = NULL

[grom72]

Reviewed 2 of 26 files at r1.
Reviewable status: 25 of 27 files reviewed, 3 unresolved discussions (waiting on @ldorau)

[ldorau]

Reviewable status: 25 of 27 files reviewed, 3 unresolved discussions (waiting on @grom72)

---

prov/sharp/src/sharp_domain.c line 264 at r3 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Return value to be converted to libfabric specific error code FI_E...

How do you want to convert enum sharp_error_no to FI_E... ?

---

prov/sharp/src/sharp_domain.c line 233 at r4 (raw file):

	struct sharp_coll_config config = { /* XXX */
/* ??? */	.ib_dev_list = NULL,		/**< IB device name, port list. (const char *) */
/* ??? */	.user_progress_num_polls = 0,	/**< Number of polls to do before calling user progress. (int) */

Done.

---

prov/sharp/src/sharp_domain.c line 247 at r4 (raw file):

		.world_local_rank = 0,			/**< relative rank of this process on this node within its job. */
/* ??? */	.enable_thread_support = 0,		/**< enable multi threaded support. */
/* ??? */	.oob_ctx = context,			/**< context for OOB functions in sharp_coll_init */

Done.

[ldorau]

Moved to:
https://reviewable.io/reviews/grom72/libfabric/4
grom72#4

Reviewable status: 25 of 38 files reviewed, 3 unresolved discussions (waiting on @grom72)

[ldorau]

Moved to:
https://reviewable.io/reviews/grom72/libfabric/4
grom72#4

[ldorau]

Reviewed 20 of 26 files at r1, 1 of 2 files at r2, 1 of 2 files at r3, 2 of 3 files at r4, all commit messages.
Reviewable status: 23 of 27 files reviewed, 3 unresolved discussions (waiting on @ldorau)

prov/sharp/src/sharp_domain.c line 264 at r3 (raw file):

err_free_domain:
	free(domain);
	return ret;

Return value to be converted to libfabric specific error code FI_E...

Code quote:

ret

Done