Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored code #44

Open
wants to merge 50 commits into
base: main
Choose a base branch
from
Open

Refactored code #44

wants to merge 50 commits into from

Conversation

NgaseBupe
Copy link
Contributor

Done:

  • Refactored entire FxpConversion Module
  • Configured fxpCoversion details API
  • Fixed RowClick not working in FxpConversion Details Modal
  • Fixed a bug that caused /transfers/{transferId}/details and /fxpConversions/{conversionId}/details to be called twice.

To be done:
Mapping the API Endpoints for the following Charts on the FXP Conversions Overview Dashboard:

  • FxpConversions Successful Percentage:
  • FxpConversions average time:
  • FxpConversions Status:
  • FxpConversions errors:

@mwan9ilwa mwan9ilwa marked this pull request as ready for review September 27, 2024 07:22
@mwan9ilwa mwan9ilwa requested a review from vijayg10 October 1, 2024 08:20
@mwan9ilwa mwan9ilwa enabled auto-merge (squash) October 1, 2024 08:22
@mwan9ilwa mwan9ilwa disabled auto-merge October 1, 2024 08:22
@@ -0,0 +1,15 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use this file to gitignore. We don't usually commit IDE specific files

Comment on lines +1 to +13
{
"transferId": "1234567890",
"transferState": "succeeded",
"direction": "INBOUND",
"transactionType": "TRANSFER",
"confirmationNumber": 0,
"sendAmount": "8",
"sendCurrency": "AED",
"dateSubmitted": "2024-08-28T09:43:39.199Z",
"receiveAmount": "7.99",
"receiveCurrency": "AED",
"conversionSubmitted": "2023-12-25T14:17:09.663+01:00",
"senderDetails": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to move it to test folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants