feat: Allow metadata and agent repo URL to be set in cluster resource #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converting to draft as I will also add Helm repo URL here. |
maciaszczykm
changed the title
michaeljguarino
approved these changes
Apr 17, 2024
maciaszczykm
deleted the
marcin/eng-1976-allow-metadata-to-be-set-in-cluster-resource-w-terraform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed also a bug that appeared on second apply for BYOK cluster. It was caused by desired version and node pools being unknown.
Tested:
Fixes ENG-1959 as well.