Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend service with templated flag #27

Merged
merged 2 commits into from
Feb 20, 2024
Merged

extend service with templated flag #27

merged 2 commits into from
Feb 20, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Feb 19, 2024

No description provided.

maciaszczykm
maciaszczykm approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@maciaszczykm maciaszczykm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you just need to run generate targets from Makefile before merging.

@zreigz zreigz merged commit 866c593 into main Feb 20, 2024
6 of 8 checks passed
@zreigz zreigz deleted the templated branch February 20, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@floreks floreks Awaiting requested review from floreks

Assignees

@maciaszczykm maciaszczykm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @maciaszczykm