Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update goreleaser.yaml #557

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: update goreleaser.yaml #557

merged 1 commit into from
Oct 2, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Oct 2, 2024

Summary

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks self-assigned this Oct 2, 2024
@floreks floreks marked this pull request as draft October 2, 2024 14:32
@floreks floreks marked this pull request as ready for review October 2, 2024 14:40
michaeljguarino
michaeljguarino approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the overrides gone?

@floreks floreks added the bug-fix This pull request fixes a bug label Oct 2, 2024
@floreks
Copy link
Member Author

floreks commented Oct 2, 2024 •
edited
Loading

They do not have any effect currently since CGO_ENABLED=0 is already set for all targets: https://github.com/pluralsh/plural-cli/pull/557/files#diff-7326b55c062b0f46fe9e39aace0a25f4515cf206040fb91a6fd2cae839f5e826L26-L27

It was used to override CGO_ENABLED flag for the builds that could not have UI enabled and the embedded UI required CGO_ENABLED=1. It was just a leftover.

@floreks floreks merged commit 66f4ee9 into main Oct 2, 2024
11 of 14 checks passed
@floreks floreks deleted the fix/goreleaser branch October 2, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

@zreigz zreigz Awaiting requested review from zreigz zreigz is a code owner

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm maciaszczykm is a code owner

Assignees

@floreks floreks

Labels
bug-fix This pull request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floreks @michaeljguarino