Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix plural version #556

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix plural version #556

merged 1 commit into from
Oct 2, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Oct 2, 2024

Fix LDFLAGS to support plural version command

Summary

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz added the bug-fix This pull request fixes a bug label Oct 2, 2024
@michaeljguarino michaeljguarino merged commit 79c394a into main Oct 2, 2024
13 of 14 checks passed
@michaeljguarino michaeljguarino deleted the plural-version branch October 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

@floreks floreks Awaiting requested review from floreks floreks is a code owner

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm maciaszczykm is a code owner

Assignees

@michaeljguarino michaeljguarino

Labels
bug-fix This pull request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @michaeljguarino