Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(template): allow overriding chart enabled field through templating #444

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(template): allow overriding chart enabled field through templating #444

wants to merge 3 commits into from
+52 −7

Conversation

floreks
Copy link
Member

@floreks floreks commented Sep 6, 2023

Summary

This will allow adding conditional logic to enable/disable helm modules via i.e. values.yaml.tpl file.

Test Plan

Locally

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks added the enhancement New feature or request label Sep 6, 2023
davidspek
davidspek approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@davidspek davidspek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@floreks
Copy link
Member Author

floreks commented Sep 6, 2023 •
edited
Loading

@davidspek is it expected for the docker builds to fail? Any known issue or just GitHub flakiness?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidspek davidspek davidspek approved these changes

@michaeljguarino michaeljguarino Awaiting requested review from michaeljguarino michaeljguarino is a code owner

@zreigz zreigz Awaiting requested review from zreigz zreigz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floreks @davidspek