Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Sidebar #49

Merged
merged 11 commits into from
May 20, 2022
Merged

Implement new Sidebar #49

merged 11 commits into from
May 20, 2022

Conversation

dherault
Copy link
Contributor

According to Design System changes.

Resolves PLU-48

@dherault dherault added enhancement New feature or request typescript Types and definitions design Anything design-related labels May 19, 2022
@dherault dherault requested a review from michaeljguarino May 19, 2022 18:34
@dherault dherault self-assigned this May 19, 2022
@dherault dherault marked this pull request as draft May 19, 2022 18:34
@github-actions
Copy link

github-actions bot commented May 19, 2022

Visit the preview URL for this PR (updated for commit 493cc35):

https://pluralsh-design--pr49-new-sidebar-ibwt5h1y.web.app

(expires Fri, 27 May 2022 18:17:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@dherault dherault marked this pull request as ready for review May 20, 2022 17:50
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small naming tweak but otherwise very cool

email: '[email protected]',
},
userName: 'Jane Smith',
userOrganization: 'Plural',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably keep the naming here in line with the api, which has it as account not organization

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, np

@dherault dherault merged commit 3bd012a into main May 20, 2022
@dherault dherault deleted the new-sidebar branch May 20, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Anything design-related enhancement New feature or request typescript Types and definitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants