-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new Sidebar #49
Conversation
Visit the preview URL for this PR (updated for commit 493cc35): https://pluralsh-design--pr49-new-sidebar-ibwt5h1y.web.app (expires Fri, 27 May 2022 18:17:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small naming tweak but otherwise very cool
email: '[email protected]', | ||
}, | ||
userName: 'Jane Smith', | ||
userOrganization: 'Plural', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably keep the naming here in line with the api, which has it as account
not organization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, np
According to Design System changes.
Resolves PLU-48