Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CI github action #283

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: CI github action #283

merged 2 commits into from
Sep 25, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Sep 25, 2024

Releasing dev image from main was failing for a long time due to broken semantic release configuration. Got rid of it as we don't need it on main.

@floreks floreks self-assigned this Sep 25, 2024
@floreks floreks added the bug Something isn't working label Sep 25, 2024
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the standard tag based release still work? (Pretty sure this is fine just curious)

@floreks
Copy link
Member Author

floreks commented Sep 25, 2024

oh yeah, this was a part of the CI action. It was supposed to create the release on every push to the main, but we have decided to rely on manual tag creation later on. The publish action in a separate file handles our standard release process.

@floreks floreks merged commit de0d62f into main Sep 25, 2024
31 checks passed
@floreks floreks deleted the fix/ci-check branch September 25, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants