feat: add job timeout #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +43,7 @@ import ( | |||
| ) | |||
|
|
|||
| const jobSelector = "stackrun.deployments.plural.sh" | |||
| const jobTimout = time.Minute * 10 | |||
There was a problem hiding this comment.
Think this should be 30 or 60 minutes (could have a weird scheduling edge case that takes 10 minutes for benign reasons I think)
| @@ -72,15 +74,24 @@ func (r *StackRunJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) | |||
| // Update step statuses, i.e., when stack run was successful or failed. | |||
| for _, step := range stackRun.Steps { | |||
There was a problem hiding this comment.
Oh we should actually not do these updates here (let the harness fully own them and it isn't going to impact anything on the api if they remain pending)
| } | ||
| } | ||
|
|
||
| // Exit if stack run is not in running state (run status already updated), | ||
| // or if the job is still running (harness controls run status). | ||
| if stackRun.Status != console.StackStatusRunning || job.Status.CompletionTime.IsZero() { | ||
| return ctrl.Result{}, nil | ||
| if isActiveJobTimout(stackRun.Status, job) { |
There was a problem hiding this comment.
I think we should also manually delete the job here, or perhaps kill its pod. I'm not sure if the ttl on the job will pick up
|
@michaeljguarino PTAL |
michaeljguarino
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add time out for stack run job reconciliation. After timeout mark the stack run with an error state.