use the same base for comparison

pluralsh · Sep 27, 2024 · de48f6a · de48f6a
1 parent ea789da
commit de48f6a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/internal/controller/upgradeinsights_cloudprovider.go b/internal/controller/upgradeinsights_cloudprovider.go
@@ -126,9 +126,9 @@ func (in *EKSCloudProvider) fromInsightStatus(status *types.InsightStatus) *cons
 }
 
 func (in *EKSCloudProvider) fromClientStats(stats []types.ClientStat) *console.UpgradeInsightStatus {
-	const failedBeforeDuration = int64(24 * time.Hour)
+	const failedBeforeDuration = 24.0 // in hours
 	for _, stat := range stats {
-		if stat.LastRequestTime != nil && time.Now().Sub(*stat.LastRequestTime).Milliseconds() < failedBeforeDuration {
+		if stat.LastRequestTime != nil && time.Now().Sub(*stat.LastRequestTime).Hours() < failedBeforeDuration {
 			return lo.ToPtr(console.UpgradeInsightStatusFailed)
 		}
 	}