Merge pull request #4 from pluralsh/master

minor fixes

Makefile

@@ -48,7 +48,7 @@ generate-spec:
 	echo "// Code generated by make; DO NOT EDIT." > "$(DATABASE_PROTO)"
 	cat $(DATABASE_SPEC) | sed -n -e '/```protobuf$$/,/^```$$/ p' | sed '/^```/d' >> "$(DATABASE_PROTO)"
 
-build-spec: generate-spec
+build-spec: generate-spec ## Generate gRPC client and server code.
 	protoc "$(DATABASE_PROTO)" \
         --go_out=. \
         --go_opt=paths=source_relative \

README.md

@@ -1,6 +1,8 @@
 # Database Interface API
 
-This repository hosts the API defintion of the Custom Resource Definitions (CRD) used for the Database Interface project.
+This repository hosts the API defintion of the Custom Resource Definitions (CRD) used for the Database Interface project
+and gRPC API for the Database standard [gRPC specification](spec/README.md).
+
 The provisioned unit of storage is a `Database`. The following CRDs are defined for managing the lifecycle of Databases:
 
 - DatabaseRequest - Represents a request to provision a Database

apis/database/v1alpha1/databaseaccessclass_types.go

@@ -24,7 +24,7 @@ type DatabaseAccessClass struct {
 	AuthenticationType AuthenticationType `json:"authenticationType"`
 
 	// Parameters is an opaque map for passing in configuration to a driver
-	// for granting access to a bucket
+	// for granting access to the database
 	// +optional
 	Parameters map[string]string `json:"parameters,omitempty"`
 }

apis/database/v1alpha1/databaseclass_types.go

@@ -34,7 +34,7 @@ type DatabaseClass struct {
 	DriverName string `json:"driverName"`
 
 	// Parameters is an opaque map for passing in configuration to a driver
-	// for creating the bucket
+	// for creating the database
 	// +optional
 	Parameters map[string]string `json:"parameters,omitempty"`
 }

apis/database/v1alpha1/databaserequest_types.go

@@ -27,9 +27,6 @@ type DatabaseRequestSpec struct {
 	// DatabaseClassName name of the DatabaseClass
 	DatabaseClassName string `json:"databaseClassName,omitempty"`
 
-	// Engine name
-	Engine string `json:"engine"`
-
 	// Name of a database object.
 	// If unspecified, then a new Database will be dynamically provisioned
 	// +optional

config/crd/bases/database.plural.sh_databaseaccessclasses.yaml

@@ -41,7 +41,7 @@ spec:
             additionalProperties:
               type: string
             description: Parameters is an opaque map for passing in configuration
-              to a driver for granting access to a bucket
+              to a driver for granting access to the database
             type: object
         required:
         - authenticationType

config/crd/bases/database.plural.sh_databaseclasses.yaml

@@ -38,7 +38,7 @@ spec:
             additionalProperties:
               type: string
             description: Parameters is an opaque map for passing in configuration
-              to a driver for creating the bucket
+              to a driver for creating the database
             type: object
         required:
         - driverName

config/crd/bases/database.plural.sh_databaserequests.yaml

@@ -45,15 +45,10 @@ spec:
               databaseClassName:
                 description: DatabaseClassName name of the DatabaseClass
                 type: string
-              engine:
-                description: Engine name
-                type: string
               existingBucketName:
                 description: Name of a database object. If unspecified, then a new
                   Database will be dynamically provisioned
                 type: string
-            required:
-            - engine
             type: object
           status:
             properties: