Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce lua script #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

introduce lua script #166

wants to merge 1 commit into from

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Dec 2, 2022

Summary

This PR replaces values.yaml.tpl with values.yaml.lua

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz added the enhancement New feature or request label Dec 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022 •
edited
Loading

Visit the preview URL for this PR (updated for commit 2b15703):

https://pluralsh-console--pr166-lua-template-6lwlqnsb.web.app

(expires Mon, 16 Jan 2023 13:51:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd1ffa0705acc6ef7d6db370e6bd6fc390e945ce

michaeljguarino
michaeljguarino requested changes Dec 2, 2022
View reviewed changes
Copy link
Member

@michaeljguarino michaeljguarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we mentioned previously, we should hold off on this until we're 100% sure lua is prod ready considering risks inherent to the console

@zreigz zreigz force-pushed the lua-template branch 4 times, most recently from ce0a47f to 0284cfb Compare December 6, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @michaeljguarino