fix form toggles #1398
Merged
fix form toggles #1398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsladerman
added
bug-fix
michaeljguarino
approved these changes
Sep 18, 2024
jsladerman
force-pushed
the
jake/prod-2645-toggles-should-default-values-to-false
branch
from
bf09095
to
3826329
Compare
jsladerman
deleted the
jake/prod-2645-toggles-should-default-values-to-false
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smtp and pr automation forms were both having issues capturing toggle values (smtp form wasn't actually setting the default to "false" so it would register undefined if there was no toggle, and conversely pr automation form was treating false as undefined)