Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "Serial Keys" to "Keys" #357

Closed
wants to merge 1 commit into from
Closed

Change "Serial Keys" to "Keys" #357

wants to merge 1 commit into from

Conversation

bappi
Copy link
Contributor

@bappi bappi commented Aug 6, 2023

For future-proofing the term.

@sultann
Copy link
Contributor

sultann commented Aug 10, 2023

@bappi I am putting this on hold for now, as it might introduce new bugs for non-English language but I will be back on this later for sure.

@sultann sultann added the Upcoming This are coming upcoming updates label Aug 10, 2023
@bappi bappi changed the base branch from master to release/v1.6.0 August 28, 2023 05:42
@kawsarahmedr kawsarahmedr self-assigned this Jan 23, 2025
@kawsarahmedr
Copy link
Member

kawsarahmedr commented Jan 23, 2025

We have already updated the plugin name to 'Serial Numbers' and the list table to 'Serial Keys,' so I will close this pull request.

In addition, we have another similar plugin named 'WC Key Manager,' the admin menu called 'Key Manager,' and the list table called 'Keys.'

We are not currently accepting the name change request to ensure that both plugins are separated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upcoming This are coming upcoming updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants