-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migration of @nivo/core
to typescript and (partial) upgrade to React 18
#2046
base: master
Are you sure you want to change the base?
Conversation
…ns highlighted by lint warnings
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Great work! |
hi @plouc , |
Bump pleeease! :-) |
@tkonopka React 18 introduces a new way to render to the dom. here is what that looks like
PS. would love to get this into React 18 |
Hi @srowe0091. Yes, but that setup code is managed by storybook (nivo packages add components to an app that is already running). The appropriate initialization is supposed to be automatic, but here storybook seems to pick the pre-18 approach, which means the configuration or dependencies need adjustment. In a different project, I managed the switch by re-installing storybook from scratch, so that is an option. |
Addresses #1219, #884 (partially)
Summary
@nivo/core
to typescript@nivo/recompose
frompackages
todeprecated
.@nivo/tooltip
into@nivo/core
. They had mutual peer dependencies, and I couldn't get them to build separately.line
andwaffle
, alsogeo
andparallel-coordinates
). These packages are non-functioning in this branch.@nivo/core
and pass build/lint/testpackages/core/migration.md
Checks
make init
(building all packages from scratch)make packages-lint
make packages-test
(but non-typescript tests are disabled)make storybook
and produces working charts (but non-typescript charts are disabled)Open issues / questions
@plouc, I set this as 'draft' to signal that it shouldn't be merged at this stage. But I hope some of it is useful. With your comments, we can extend this to address the issues, or move some material into smaller updates. Thanks!