BaseValue issue resolved

[harshpurwar]

This PR resolves issue231

Sample code to try:

y = [8 15 33; 30 35 40; 50 55 62];
barh(y,'BaseValue',25)

fig2plotly(gcf, 'offline', false);

NOTE: You may see a warning for missing tickvals, but since strip is set to false and tickvals is indeed a correct property for x/y axis, this still works. Let's discuss on Slack how to update plotly/plotly_help_aux/plotly_reference.mat after which this warning would disappear automatically.

Vertical bars without Basevalue argument...

Horizontal bars with BaseValue=25

Vertical bars with BaseValue=30

[VolKa79]

Graph is good, but getting the next warnings:

warning: error using update_opac
warning: error using update_opac
warning: error using update_opac
Whoops! Reference to non-existent field 'tickvals' in xaxis

[jackparmer]

Graph is good, but getting the next warnings...

@VolKa79 Purwar already mentioned this

NOTE: You may see a warning for missing tickvals, but since strip is set to false and tickvals is indeed a correct property for x/y axis, this still works. Let's discuss on Slack how to update plotly/plotly_help_aux/plotly_reference.mat after which this warning would disappear automatically.

[xarico10]

I do get the warning message but I'm not getting the correct graph:

y = [8 15 33; 30 35 40; 50 55 62];
barh(y,'BaseValue',25)

fig2plotly(gcf, 'offline', false);

[harshpurwar]

Hello @xarico10

Are you sure you are using the right branch for this? Please do verify it once more.

git checkout issue231
git pull

Make sure that the git checkout actually worked. If you have any uncommitted changes, make sure to either reset the repo git reset --hard (you will lose your changes) or stash your changes git stash before checking out this branch.

What all warnings do you get? Also, what MATLAB version did you try this on?

[xarico10]

I was missing the Deep Learning Toolbox that is needed. Works for me now, printing the warning message you mentioned.

[xarico10]

@jackparmer Please let me know if we wanna merge this, even with the warning message mentioned.

[harshpurwar]

I am working on resolving these warnings. We can merge this or wait for some time until I resolve this, I don't mind.

[harshpurwar]

This PR now also updates the Plotly JSON schema.
I tested it thoroughly for bars (no warnings). Although there may still be some warnings for other plot types (or traces) due to the updated JSON structure. Certain field properties are deprecated, like titlefont, xref/yref for legends, etc.

@jackparmer When your testing framework with Kaleido is ready, we could test this to see what warnings we get and for what trace types. Until then, I think the only option is to check this manually for various trace types.

I will inform others about the warning messages and what to do if they do see these on Slack.