Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue233 #321

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Issue233 #321

wants to merge 7 commits into from

Conversation

benaliabderrahmane
Copy link
Contributor

fixing issue 233

matlab code:

y = [90,75,30,60,5,40,40,5];
figure
pareto(y)

fig2plotly(gcf, 'offline', false);

results:

1001

@benaliabderrahmane benaliabderrahmane linked an issue Aug 6, 2021 that may be closed by this pull request
@jackparmer jackparmer requested review from VolKa79 and xarico10 August 7, 2021 01:16
@xarico10
Copy link
Contributor

xarico10 commented Aug 8, 2021

Please remember to reference issue's link in the comments. Like this: issue #233

Copy link
Contributor

@xarico10 xarico10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting the following error:

Unrecognized method, property, or field 'Type' for
class 'matlab.graphics.GraphicsPlaceholder'.

Error in plotlyfig/update (line 502)
                    if ((mean(eq(ax(i).Position,
                    ax(j).Position)) == 1) && (i~=j)
                    && strcmp(ax(i).Children.Type,
                    'histogram'))

Error in plotlyfig (line 216)
                obj.update;

Error in fig2plotly (line 44)
p = plotlyfig(varargin{:});

Error in untitled (line 6)
fig2plotly(gcf, 'offline', false);

@xarico10
Copy link
Contributor

xarico10 commented Aug 8, 2021

Also, in line 506 and 507 in plotly/plotlyfig.m the variable update_opac seems to be changing size in every loop iteration. Please preallocate it (create the variable before the for loop with its final size) for better computational performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Axes issues when using pareto()
2 participants