Allow users to set Kaleido path via environment variable #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-ng
changed the title
andrei-ng
force-pushed
the
develop
branch
12 times, most recently
from
396d6ef to
5d5b04f
Compare
- introduced a new feature to allow users to download Kaleido at compile time when the applications are targeted for the host machine - this can be overriden by the runtime environment variable Signed-off-by: Andrei Gherghescu <[email protected]>
- something fishy is happening in the CI, without this argument empty files are generated because of chromium security issues - print stderr of Kaleido to console Signed-off-by: Andrei Gherghescu <[email protected]>
andrei-ng
force-pushed
the
develop
branch
2 times, most recently
from
a4c55eb to
30148f5
Compare
Signed-off-by: Andrei Gherghescu <[email protected]>
andrei-ng
changed the title
andrei-ng
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #216