-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed the expected type for HeatMap.z
from Option<Vec<Z>>
to Option<Vec<Vec<Z>>>
#157
Conversation
added `customized_heat_map` function to showcase the working zmin and zmax
Going to look into the failed tests |
Signed-off-by: Andrei Gherghescu <[email protected]>
Hi @tectin0. Thank for looking into this issue, for the PR and for the nice example you've added. I had a bit more time to look into it. As you clearly identified, indeed there is a problem when With However, for this issue I would rather go a different path and force the type for those setters to be I pushed a commit on top of your PR with that change. @tectin0 do you agree? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
- Coverage 93.61% 93.56% -0.05%
==========================================
Files 27 28 +1
Lines 7153 7215 +62
==========================================
+ Hits 6696 6751 +55
- Misses 457 464 +7 ☔ View full report in Codecov by Sentry. |
As @tectin0 gave me a 👍 , I will merge it. |
With
Vec<Vec<T>>
as an input forHeatMap.z
it infers thatZ
has the typeVec<T>
instead ofT
. This prevents.zmin()
and.zmax()
from working.Example:
Changing the type to
Option<Vec<Vec<Z>>
results in a correctly inferred type ofZ
and.zmin()
and.zmax()
work correctlyalso added
customized_heat_map
function to showcase the working zmin and zmax