Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on lazyeval #2319

Closed
wants to merge 5 commits into from
Closed

Drop dependency on lazyeval #2319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a251e26
Fix link to repo + add headings in news
olivroy Nov 23, 2023
f3c11d7
Use rlang::check_installed() over custom helper `try_library()`.
olivroy Nov 23, 2023
5b6cc1c
Fix roxygen2 warnings
olivroy Nov 23, 2023
ffa1878
Remove lazyeval import (inspired by https://github.com/tidyverse/ggpl…
olivroy Nov 23, 2023
163483c
Update crosstalk version to 1.2.1
olivroy Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Opening issues

See the [opening issues template](https://github.com/ropensci/plotly/blob/master/.github/ISSUE_TEMPLATE.md)
See the [opening issues template](https://github.com/plotly/plotly.R/blob/master/.github/ISSUE_TEMPLATE.md)

## Development guidelines

Expand All @@ -15,7 +15,7 @@ If your pull request fixes a bug and/or implements a new feature, please [write
To ensure a consistent and reproducible environment, visual tests should be run against the [cpsievert/plotly-orca](https://hub.docker.com/r/cpsievert/plotly-orca/) docker image. If you add a new visual test and/or expect any differences, run a container like so:

```shell
git clone https://github.com/ropensci/plotly.git
git clone https://github.com/plotly/plotly.R.git
cd plotly
docker run -v $(pwd):/home/plotly --privileged -p 3838:3838 cpsievert/plotly-orca
```
Expand All @@ -28,4 +28,4 @@ docker run -e VMODE="ci" -v $(pwd):/home/plotly --privileged cpsievert/plotly-or

## Code of Conduct

We want to encourage a warm, welcoming, and safe environment for contributing to this project. See the [code of conduct](https://github.com/ropensci/plotly/blob/master/CONDUCT.md) for more information.
We want to encourage a warm, welcoming, and safe environment for contributing to this project. See the [code of conduct](https://github.com/plotly/plotly.R/blob/master/CONDUCT.md) for more information.
1 change: 0 additions & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ Imports:
dplyr,
vctrs,
tibble,
lazyeval (>= 0.2.0),
rlang (>= 0.4.10),
crosstalk,
purrr,
Expand Down
6 changes: 1 addition & 5 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,16 +250,12 @@ importFrom(httr,write_disk)
importFrom(jsonlite,parse_json)
importFrom(jsonlite,read_json)
importFrom(jsonlite,toJSON)
importFrom(lazyeval,all_dots)
importFrom(lazyeval,f_eval)
importFrom(lazyeval,f_new)
importFrom(lazyeval,is_formula)
importFrom(lazyeval,is_lang)
importFrom(magrittr,"%>%")
importFrom(purrr,transpose)
importFrom(rlang,"!!!")
importFrom(rlang,"!!")
importFrom(rlang,eval_tidy)
importFrom(rlang,is_formula)
importFrom(rlang,is_na)
importFrom(stats,complete.cases)
importFrom(stats,is.leaf)
Expand Down
Loading
Loading