Allow to use paths with extensions in image exporter #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+22
to
+26
| let ensureFileExtension (ext: string) (path: string) = | ||
| match Path.GetExtension(path) with | ||
| | "" -> sprintf "%s%s" path ext | ||
| | e when String.Compare(e, ext, StringComparison.OrdinalIgnoreCase) = 0 -> path | ||
| | _ as e -> failwithf "Provided path contains wrong file extension. Expected '%s' got '%s'." ext e |
There was a problem hiding this comment.
Honestly, I'd just write wherever the user wants to. I think it's not smart to dictate the user what extension should be. Why can't we just write a jpg to a txt file? It would make it transparent
|
|
||
| return rendered |> getBytesFromBase64String |> fun base64 -> File.WriteAllBytes($"{path}.jpg", base64) | ||
| return rendered |> getBytesFromBase64String |> fun base64 -> File.WriteAllBytes(path, base64) |
There was a problem hiding this comment.
I 💯 agree with this change. Adding silent .jpg is imo not a good idea.
kMutagene
force-pushed
the
dev
branch
3 times, most recently
from
b5bebb8 to
e7bff82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use paths with extensions in the image exporter. This seems more natural when working with paths. To be backwards compatible add extension when it does not exists otherwise check if provided extension is correct if so use it - otherwise throw an exception to warn about misuse of export function.