Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning-less build? #102

Closed
wants to merge 2 commits into from
Closed

Warning-less build? #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe44447
Warnings suppressed ; warnings treated as errors
WhiteBlackGoose Aug 4, 2021
826da21
TODOs added
WhiteBlackGoose Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/Plotly.NET/CandelstickExtension.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,21 @@
namespace Plotly.NET


// This disables FS0044, which is about using
// obsolete API (marked with Obsolete attribute).
//
// It is needed because there are warnings coming
// from the obsolete functions using obsolete API.
//
// However, it will hide using actually obsolete
// API not used in obsolete API.
//
// TODO: remove when
// https://github.com/fsharp/fslang-suggestions/issues/278
// or https://github.com/fsharp/fslang-suggestions/issues/1055
// is implemented
#nowarn "44"

open Trace
open System
open System.Runtime.InteropServices
Expand Down
15 changes: 15 additions & 0 deletions src/Plotly.NET/Chart.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
namespace Plotly.NET

// This disables FS0044, which is about using
// obsolete API (marked with Obsolete attribute).
//
// It is needed because there are warnings coming
// from the obsolete functions using obsolete API.
//
// However, it will hide using actually obsolete
// API not used in obsolete API.
//
// TODO: remove when
// https://github.com/fsharp/fslang-suggestions/issues/278
// or https://github.com/fsharp/fslang-suggestions/issues/1055
// is implemented
#nowarn "44"

open System
open System.IO
//open FSharp.Care.Collections
Expand Down
7 changes: 7 additions & 0 deletions src/Plotly.NET/Plotly.NET.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,12 @@
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
<Configurations>Debug;Release;Dotnet</Configurations>
</PropertyGroup>

<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<WarningsAsErrors />
</PropertyGroup>

<PropertyGroup>
<Authors>Timo Mühlhaus, Kevin Schneider, F# open source contributors</Authors>
<Description>plotly.js charts in .NET programming languages 📈🚀. </Description>
Expand All @@ -31,6 +37,7 @@
<FsDocsLicenseLink>https://github.com/plotly/Plotly.NET/blob/dev/LICENSE</FsDocsLicenseLink>
<FsDocsReleaseNotesLink>https://github.com/plotly/Plotly.NET/blob/dev/RELEASE_NOTES.md</FsDocsReleaseNotesLink>
</PropertyGroup>

<ItemGroup>
<None Include="..\..\docs\img\logo.png" Pack="true" PackagePath="\" />
<Compile Include="AssemblyInfo.fs" />
Expand Down