Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Adding Auto Check / Instant Kill #74

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix & Adding Auto Check / Instant Kill #74

wants to merge 6 commits into from

Conversation

K0bus
Copy link

@K0bus K0bus commented Apr 13, 2020

Little update for fixing error when kill Pillager or any entities have more than 20 HP.
Also adding two features :

  • Auto Check : Every X time check all entities for adding them in Stack because already spawned entities don't be stacked before.
  • Instant Kill : Check some DamageCause for killing all Stack on many farm.

@ploppyperson
Copy link
Owner

ploppyperson commented Apr 13, 2020

"Instant Kill" can already be achieved with the current config system - thats the entire point of the priority system. I have made an example of this: https://gist.github.com/Nathat23/2fd312df702424401679c40810feb0a3

The "Auto Check" seems incredibly wasteful. What's the point of duplicating the stacking logic - why not just set the stack value to one and let the stacking task do its job? It would also be more efficient to do this on chunk load rather than as a task. And there are also other considerations to be made, some mobs might not supposed to be stacked, which is why the current implementation is a command, '/sm forcestack'

The fix for the max health error is the obvious one, however there may be a different reasons for the health disparity between the new + old entity, which should be investigated.

It is important to think carefully about the effects of your code and consider why things are the way they are. I appreciate the attempt and effort though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants