Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy.md add hints on restrictions on availability of Environ… #921

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

acsr
Copy link
Contributor

@acsr acsr commented Jan 29, 2025

…ments and how to find explicit values in the README

Further improvements This can be cross linked to the creation of the repo, where I suggested a similar hint.


📚 Documentation preview 📚: https://plone-training--921.org.readthedocs.build/

…ments and how to find explicit values in the README

Further improvements This can be cross linked to the creation of the repo, where I suggested a similar hint.
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Some grammar and MyST syntax improvements. Also align with other PR about GitHub Pro.

@stevepiercy stevepiercy merged commit 135fd30 into main Jan 30, 2025
2 of 3 checks passed
@stevepiercy stevepiercy deleted the acsr-patch-Github-Repo-Type-hints+pointer-to-README branch January 30, 2025 13:04
@acsr
Copy link
Contributor Author

acsr commented Jan 30, 2025

Please match this one again finally with the correction I made related to the GitHub Pro level in the other Pull request #920

@stevepiercy
Copy link
Contributor

Done in bb35126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants