Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add available languages information to the @site endpoint #1738

Merged
merged 9 commits into from
Mar 3, 2024

Conversation

erral
Copy link
Member

@erral erral commented Dec 7, 2023

No description provided.

Copy link

netlify bot commented Dec 7, 2023

Deploy Preview for plone-restapi canceled.

Name Link
🔨 Latest commit 56b4c43
🔍 Latest deploy log https://app.netlify.com/sites/plone-restapi/deploys/65e3d2b6ad47760008e11629

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral
Copy link
Member Author

erral commented Dec 7, 2023

@jenkins-plone-org please run jobs

Copy link
Member

@tisto tisto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition. @erral just out of curiosity, could you share your use case?

@robgietema any objections from your point of view regarding Nick?

@tisto
Copy link
Member

tisto commented Jan 23, 2024

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Jan 28, 2024

My initial idea was to allow Volto to get multilingual settings from the configuration at the backend, see plone/volto#5506

There are some challenges there though.

In any case, I think that it would be a great addition to the rest api.

@tisto
Copy link
Member

tisto commented Feb 16, 2024

@jenkins-plone-org please run jobs

@erral
Copy link
Member Author

erral commented Feb 28, 2024

@jenkins-plone-org please run jobs

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@davisagli davisagli merged commit 3709074 into main Mar 3, 2024
21 of 25 checks passed
@davisagli davisagli deleted the erral-site-languages branch March 3, 2024 02:10
tisto added a commit that referenced this pull request Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants