-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes "by" translation and fuzzy dates for document_byline.pt
#369
base: master
Are you sure you want to change the base?
Conversation
@szakitibi thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought i18ndude
would complain about the label_by_author
, because we are repeating over the authors, but I tried, and it works fine.
I have a doubt about how to show the modified/published dates. It might have been a conscious decision to not show these fuzzy dates. I tested your branch, and it works, but I have no opinion here. I will ask a review from someone else.
Actually most preferred to see an absolute date and time, so it was a conscious decision some years ago to drop relative time display. If you need this: best way to get it back is to add a setting to the date and time control panel and use it in the templates. additions to this PR welcome. |
Reverted the fuzzy date changes, since it was a conscious decision. |
@szakitibi The lint checks are failing. Run "make format" to automatically format document_byline.pt |
published/modified dates
The document byline viewlet used to have fuzzy dates in Plone 5 - see #61 and plone/Products.CMFPlone#1000, which has been replaced in Plone 6 with simpl localized date.
It lacks the information of when exactly the document has been modified, e.g. after editing a document I prefer seeing "last modified a few seconds ago" instead of the current date.
"by" translation
The
label_by_author
translation worked for most of the languages in Plone 5. It has been changed with commit 2d6f75 tolabel_by
. Based on a quick search inplone.app.locales
the new translation has only 7 translations out of65 languages. The original
label_by_author
is much more supported with 46 translations out of the 65 languages.