WIP: delete README.txt from analytics sub package #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are also the Moving the code around is a breaking change... Not sure, if there is any persistence involved like with portlets, which will break the site. Ideally much of the code, especially the global views, navigation and sitemap code should go into CMFPlone. But that's possibly something for Plone 6. |
mauritsvanrees
changed the title
It had outdated information anyway.
gforcada
force-pushed
the
gforcada-patch-1
branch
from
6dc8ac4
to
714776b
Compare
|
@thet good points, so let's just remove this file and don't move things around, would that be fine? |
|
You can move stuff around when providing BBB imports and deprecation warnings, then its not a breaking change. |
|
see #132 |
talarias
pushed a commit
that referenced
this pull request
Dec 9, 2021
Make search button grow with the search buttons text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It had outdated information anyway.
Question: should the code on that package be moved to viewlets with all the other viewlets? Does not make much sense to have two locations with viewlets...