update axios version #329
Merged
update axios version #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishnukumarpg
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
There are breaking changes in between 3 versions:
- https://github.com/axios/axios/releases/tag/v0.27.0
- https://github.com/axios/axios/releases/tag/v0.25.0
- https://github.com/axios/axios/releases/tag/v0.24.0
Are these validated?
| @@ -7,7 +7,7 @@ export function validateSignature(uri: string, nonce: string, signature: string, | |||
| * You can also pass in additional parameters accepted by the node requests module. | |||
| */ | |||
| export class Client { | |||
| constructor(authId?: string, authToken?: string, options?: string); | |||
| constructor(authId?: string, authToken?: string, options?: any); | |||
There was a problem hiding this comment.
@narayana-plivo I believe the same line change we need to update in the client-test.d.ts file right?
There was a problem hiding this comment.
@kalyan-plivo currently its passed with constructor(authid: string, authToken: string, proxy: string); Not object.
i have verified most of the our api. |
PratikKataria-plivo
approved these changes
Apr 2, 2024
|
Hey Plivo Team! What's holding this PR from being merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.