Skip to content

Commit

Permalink
Merge pull request #242 from plivo/VT-5519
Browse files Browse the repository at this point in the history
Added new recording params and filter
  • Loading branch information
abhishekGupta-Plivo authored May 31, 2023
2 parents aea10c3 + 19338d5 commit 13e5eba
Show file tree
Hide file tree
Showing 9 changed files with 60 additions and 10 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Change Log

## [5.25.0](https://github.com/plivo/plivo-java/tree/v5.25.0) (2023-05-29)
- Added `monthly_recording_storage_amount`, `recording_storage_rate`, `rounded_recording_duration`, and `recording_storage_duration` parameters to the response for [get single recording API](https://www.plivo.com/docs/voice/api/recording#retrieve-a-recording) and [get all recordings API](https://www.plivo.com/docs/voice/api/recording#list-all-recordings)
- Added `recording_storage_duration` parameter as a filter option for [get all recordings API](https://www.plivo.com/docs/voice/api/recording#list-all-recordings)

## [5.24.0](https://github.com/plivo/plivo-java/tree/v5.24.0) (2023-05-04)
- Add New Param `renewalDate` to the response of the [list all numbers API], [list single number API]
- Add 5 new filters to AccountPhoneNumber - list all my numbers API:`renewal_date`, `renewal_date__gt`, `renewal_date__gte`,`renewal_date__lt` and `renewal_date__lte` (https://www.plivo.com/docs/numbers/api/account-phone-number#list-all-my-numbers)
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,21 +10,21 @@ The Plivo Java SDK makes it simpler to integrate communications into your Java a

### To Install Stable release

You can use this SDK by adding it as a dependency in your dependency management tool. Alternatively, you can use the [JAR file](https://search.maven.org/remotecontent?filepath=com/plivo/plivo-java/5.23.0/plivo-java-5.23.0.jar).
You can use this SDK by adding it as a dependency in your dependency management tool. Alternatively, you can use the [JAR file](https://search.maven.org/remotecontent?filepath=com/plivo/plivo-java/5.25.0/plivo-java-5.25.0.jar).

If you are using Maven, use the following XML to include the Plivo SDK as a dependency.

```xml
<dependency>
<groupId>com.plivo</groupId>
<artifactId>plivo-java</artifactId>
<version>5.24.0</version>
<version>5.25.0</version>
</dependency>
```

If you are using Gradle, use the following line in your dependencies.
```
compile 'com.plivo:plivo-java:5.24.0'
compile 'com.plivo:plivo-java:5.25.0'
```

### To Install Beta release
Expand Down
2 changes: 1 addition & 1 deletion pom.properties
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Written manually.

version=5.24.0
version=5.25.0
groupId=com.plivo
artifactId=plivo-java
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.plivo</groupId>
<artifactId>plivo-java</artifactId>
<version>5.24.0</version>
<version>5.25.0</version>
<name>plivo-java</name>
<description>A Java SDK to make voice calls &amp; send SMS using Plivo and to generate Plivo XML</description>
<licenses>
Expand Down
20 changes: 20 additions & 0 deletions src/main/java/com/plivo/api/models/recording/Recording.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ public class Recording extends BaseResource {
private String addTime;
private String callUuid;
private String conferenceName;
private Float monthlyRecordingStorageAmount;
private Integer recordingStorageDuration;
private String recordingDurationMs;
private String recordingEndMs;
private String recordingFormat;
Expand All @@ -15,6 +17,8 @@ public class Recording extends BaseResource {
private String recordingUrl;
private String resourceUri;
private String recordingId;
private Float recordingStorageRate;
private Integer roundedRecordingDuration;
private String fromNumber;
private String toNumber;

Expand Down Expand Up @@ -112,6 +116,22 @@ public String getRecordingUrl() {
return recordingUrl;
}

public Float getMonthlyRecordingStorageAmount() {
return monthlyRecordingStorageAmount;
}

public Integer getRecordingStorageDuration() {
return recordingStorageDuration;
}

public Float getRecordingStorageRate() {
return recordingStorageRate;
}

public Integer getRoundedRecordingDuration() {
return roundedRecordingDuration;
}

public String getResourceUri() {
return resourceUri;
}
Expand Down
10 changes: 10 additions & 0 deletions src/main/java/com/plivo/api/models/recording/RecordingLister.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ public class RecordingLister extends VoiceLister<Recording> {
private String conferenceUuid;
private String mpcUuid;
private PropertyFilter<Date> addTime;
private PropertyFilter<Integer> recordingStorageDuration;

public String subaccount() {
return this.subaccount;
Expand Down Expand Up @@ -54,6 +55,10 @@ public PropertyFilter<Date> addTime() {
return this.addTime;
}

public PropertyFilter<Integer> recordingStorageDuration() {
return this.recordingStorageDuration;
}

/**
* @param subaccount auth_id of the subaccount. Lists only those recordings of the main accounts
* which are tied to the specified subaccount.
Expand Down Expand Up @@ -127,6 +132,11 @@ public RecordingLister addTime(final PropertyFilter<Date> addTime) {
return this;
}

public RecordingLister recordingStorageDuration(final PropertyFilter<Integer> recordingStorageDuration) {
this.recordingStorageDuration = recordingStorageDuration;
return this;
}

@Override
protected Call<ListResponse<Recording>> obtainCall() {
return client().getVoiceApiService().recordingList(client().getAuthId(), toMap());
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/com/plivo/api/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
5.24.0
5.25.0
6 changes: 5 additions & 1 deletion src/test/resources/com/plivo/api/recordingGetResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@
"recording_url": "http://s3.amazonaws.com/recordings_2013/c2186400-1c8c-11e4-a664-0026b945b52x.mp3",
"resource_uri": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Recording/c2186400-1c8c-11e4-a664-0026b945b52x/",
"from_number": "+919999323467",
"to_number": "+919891865130"
"to_number": "+919891865130",
"monthly_recording_storage_amount": 0.0008,
"rounded_recording_duration": 120,
"recording_storage_duration": 209,
"recording_storage_rate": 0.0004
}
18 changes: 15 additions & 3 deletions src/test/resources/com/plivo/api/recordingListResponse.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@
"recording_url": "http://s3.amazonaws.com/recordings_2013/c2186400-1c8c-1124-a664-0026b945b522.mp3",
"resource_uri": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Recording/c2186400-1c8c-1124-a664-0026b945b522/",
"from_number": "+919999323467",
"to_number": "+919891865130"
"to_number": "+919891865130",
"monthly_recording_storage_amount": 0.0008,
"rounded_recording_duration": 120,
"recording_storage_duration": 209,
"recording_storage_rate": 0.0004
},
{
"add_time": "2014-08-05 16:05:21.993853+05:30",
Expand All @@ -36,7 +40,11 @@
"recording_url": "http://s3.amazonaws.com/recordings_2013/fc2716b0-1c8b-11e4-bwad-842b2b17453e.mp3",
"resource_uri": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Recording/fc2716b0-1c8b-11e4-bwad-842b2b17453e/",
"from_number": "+919999323467",
"to_number": "+919891865130"
"to_number": "+919891865130",
"monthly_recording_storage_amount": 0.0008,
"rounded_recording_duration": 120,
"recording_storage_duration": 209,
"recording_storage_rate": 0.0004
},
{
"add_time": "2014-08-05 15:51:56.582492+05:30",
Expand All @@ -51,7 +59,11 @@
"recording_url": "http://s3.amazonaws.com/recordings_2013/3e701c9e-1c8a-11e4-bwad-842b2b17453e.mp3",
"resource_uri": "/v1/Account/MANWVLYTK4ZWU1YTY4ZT/Recording/3e701c9e-1c8a-11e4-bwad-842b2b17453e/",
"from_number": "+919999323467",
"to_number": "+919891865130"
"to_number": "+919891865130",
"monthly_recording_storage_amount": 0.0008,
"rounded_recording_duration": 120,
"recording_storage_duration": 209,
"recording_storage_rate": 0.0004
}
]
}

0 comments on commit 13e5eba

Please sign in to comment.