chore: roll to Playwright v1.40.1 #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
files can be one of: string, []string, InputFile, []InputFile
canstand
changed the title
mxschmitt
approved these changes
Nov 30, 2023
artifact.go
Outdated
| @@ -18,7 +18,7 @@ func (a *artifactImpl) PathAfterFinished() (string, error) { | |||
| return "", errors.New("Path is not available when connecting remotely. Use SaveAs() to save a local copy") | |||
| } | |||
| path, err := a.channel.Send("pathAfterFinished") | |||
| if path == nil { | |||
| if path == nil { // < v1.40.0 | |||
There was a problem hiding this comment.
I personally would remove that, since we from the last person throw if you connect to a server which is not matching the protocol version you are using. The user use-case if that you are using the normal driver which we download for you where we ensure that the version always matches.
browser.go
Outdated
| } | ||
| // if b.isClosedOrClosing { |
errors.go
Outdated
Comment on lines
37
to
38
| ErrBrowserClosed = errors.New("Browser has been closed") | ||
| ErrBrowserOrContextClosed = errors.New("Target page, context or browser has been closed") |
There was a problem hiding this comment.
Suggested change
| ErrBrowserClosed = errors.New("Browser has been closed") | |
| ErrBrowserOrContextClosed = errors.New("Target page, context or browser has been closed") |
can't we remove these two? Ideally we only have ErrorPlaywright, ErrTimeout and ErrTargetClosed. (maybe use more Go like names, but something around these lines)
There was a problem hiding this comment.
The latest commit refactors the error type, bringing breaking changes:
ErrPlaywrightwraps all Playwright errorsErrTimeoutwraps all timeout errors and replacesTimeoutError
pls review it.
BREAKING CHANGE: - `ErrPlaywright` wraps all Playwright errors - `ErrTimeout` wraps all timeout errors and replaces `TimeoutError`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SetInputFilesnow supports both file paths and InputFile objects