feat: orama search #1131
Merged
feat: orama search #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
crutchcorn
force-pushed
the
orama-search
branch
from
09a4351
to
c0287f7
Compare
crutchcorn
commented
Oct 27, 2024
There was a problem hiding this comment.
@fennifith suggested a few small changes. We also need to add Orama to our sponsors list here:
https://playfulprogramming-git-orama-search-oceanbit.vercel.app/join-us
src/views/search/orama.tsx
Outdated
|
|
||
| export async function searchForTerm({ postClient, collectionClient }: SearchContext, query: SearchQuery, signal: AbortSignal) { | ||
| // Schema should be passed to `search` method when: | ||
| // https://github.com/askorama/oramacloud-client-javascript/pull/35 |
There was a problem hiding this comment.
This was merged. We can change this now
There was a problem hiding this comment.
This doesn't appear to be working. I'm only seeing this function in the type definitions, and not the version with generics (using the latest version):
search(query: ClientSearchParams, config?: SearchConfig): Promise<Nullable<Results<AnyDocument>>>;I'll update this comment & the client lib version, but will look into what's happening with the types later. (I don't think it should block this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our in-house Fuse.js powered search with one from Orama to make our results much better.
#sponsored (disclosure to follow soon)
TODOs
string[])*search for all resultsDeployment