Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Temporary disable grpc samples" #419

Closed
wants to merge 1 commit into from

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Oct 19, 2023

This reverts commit 108c50c.

This grpc stuff needs more work...

@mkurz
Copy link
Member Author

mkurz commented Oct 19, 2023

Also note, grep'ing for akka in the grpc examples:

play-java-grpc-example/build.sbt:  .enablePlugins(AkkaGrpcPlugin) // enables source generation for gRPC
play-java-grpc-example/build.sbt:    akkaGrpcGeneratedLanguages := Seq(AkkaGrpc.Java),
play-java-grpc-example/build.sbt:    akkaGrpcExtraGenerators += PlayJavaClientCodeGenerator,
play-java-grpc-example/build.sbt:    akkaGrpcExtraGenerators += PlayJavaServerCodeGenerator,
play-java-grpc-example/docs/src/main/paradox/code-details.md:The `AkkaGrpcPlugin` locates the gRPC `.proto` files and generates source code from it. Remember to enable the plugin
play-java-grpc-example/docs/src/main/paradox/code-details.md:### 2.a Serving (Akka) gRPC Services
play-java-grpc-example/conf/application.conf:  enabled += example.myapp.helloworld.grpc.AkkaGrpcClientModule

play-scala-grpc-example/build.sbt:  .enablePlugins(AkkaGrpcPlugin) // enables source generation for gRPC
play-scala-grpc-example/build.sbt:      akkaGrpcGeneratedLanguages := Seq(AkkaGrpc.Scala),
play-scala-grpc-example/build.sbt:      akkaGrpcExtraGenerators += PlayScalaClientCodeGenerator,
play-scala-grpc-example/build.sbt:      akkaGrpcExtraGenerators += PlayScalaServerCodeGenerator,
play-scala-grpc-example/docs/src/main/paradox/code-details.md:The `AkkaGrpcPlugin` locates the gRPC `.proto` files and generates source code from it. Remember to enable the plugin
play-scala-grpc-example/docs/src/main/paradox/code-details.md:### 2.a Serving (Akka) gRPC Services
play-scala-grpc-example/conf/application.conf:  enabled += example.myapp.helloworld.grpc.AkkaGrpcClientModule

@mkurz
Copy link
Member Author

mkurz commented Dec 19, 2023

@ihostage Just FYI, we will need that one here later.

@ihostage
Copy link
Member

Superseded by #492

@ihostage ihostage closed this Dec 27, 2023
@mkurz mkurz deleted the activate_grpc_examples branch January 9, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants