Bump play 284 #116
Bump play 284 #116
Conversation
| pushd play-scala-streaming-example && scripts/test-sbt && popd | ||
| # uses vanilla sbt | ||
| # pushd play-scala-tls-example && scripts/test-sbt && popd | ||
| pushd play-scala-websocket-example && scripts/test-sbt && popd |
There was a problem hiding this comment.
I'm sneaking this one in as an early attempt to quickly run samples locally for faster diagnosis in case of regression.
There was a problem hiding this comment.
We could add something like https://github.com/akka/akka-platform-guide/blob/main/scripts/format-all.sh and even remove the separate Travis jobs.
WDYT?
There was a problem hiding this comment.
We could add something like https://github.com/akka/akka-platform-guide/blob/main/scripts/format-all.sh and even remove the separate Travis jobs.
WDYT?
Hmm, yeah, simplifying this code is a good idea.
I'm not sure about running all tests in a single travis job. Every once in a while there's a failure here or there and having separate jobs makes it faster to diagnose. Let's merge this as is and discuss improvements in a new issue.
playframework/play-meta#166