Update upsun.json schema validator #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to align the Upsun doc with the Yaml schema described here. Related doc issue on specifics: * platformsh/platformsh-docs#4495 * platformsh/platformsh-docs#4497 * platformsh/platformsh-docs#4498 * platformsh/platformsh-docs#4499 * platformsh/platformsh-docs#4500 * platformsh/platformsh-docs#4501
mark removed keys as deprecated instead
adding `runtime` definition
adding rules to allow dot-keys on the top level but not below (except for name of services, routes and apps)
can't use/validate dot variable at the root, otherwise, title and description for each keys are not displayed in PHPStorm (validation engine crash with patternProperties def)
allow additional properties at the root of the config file (dot-key?!)
adding limited list of container_profile
container_profile authorize null value
remove "crons.commands" as required, otherwise, it's not possible to use "cmd" (and i modify the Deprecated message to add a note using "crons.commands.start" instead
spk
reviewed
Apr 22, 2025
spk
reviewed
Apr 23, 2025
spk
approved these changes
Apr 28, 2025
fabpot
requested changes
Apr 29, 2025
|
Is it possible to merge it as is and i will open a new one with incoming changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to align the Upsun doc with the Yaml schema described here.
Related doc/upsun.json issues:
container_profileon the app reference top level key platformsh-docs#4495build.cachesproperty ? platformsh-docs#4497web.locations.rulesplatformsh-docs#4498web.locations.<name>.request_buffering.max_request_sizedefault value platformsh-docs#4499workersconfig platformsh-docs#4500preflightYaml key is missing in the doc platformsh-docs#4501