Fix registration bugs, update input design, and improve validation logic #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors for input fields
…y removing client-side validation
tjementum
force-pushed
the
clean-up-account-registration
branch
from
de09d16 to
4d46319
Compare
raix
suggested changes
Jul 21, 2024
I've have never seen errors in the UI. And losing form data has been a problem since we upgraded to React 19 Canary :) |
tjementum
force-pushed
the
clean-up-account-registration
branch
2 times, most recently
from
55f921b to
cf8411e
Compare
tjementum
force-pushed
the
clean-up-account-registration
branch
3 times, most recently
from
fb7e302 to
0f51a27
Compare
tjementum
changed the title
tjementum
force-pushed
the
clean-up-account-registration
branch
from
0f51a27 to
090030d
Compare
raix
reviewed
Jul 23, 2024
application/account-management/WebApp/pages/register/verify/index.tsx
Outdated
Show resolved
Hide resolved
raix
force-pushed
the
clean-up-account-registration
branch
from
090030d to
ebb19a9
Compare
raix
force-pushed
the
clean-up-account-registration
branch
from
ebb19a9 to
04b2298
Compare
|
raix
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Fix a bug in account registration where form state is lost, and address an issue where validation errors were not shown to users. Downgrading to React 18 Canary fixes this, as these bugs were related to React 19 Canary - Waiting for React Aria Components to catch up.
Restructure frontend pages to use a shared layout and move out components from pages / routing and into shared ui for a clearer seperation of concerns.
Update the design of input fields to ensure they are all the same height.
Remove client-side validation and disable browser native validation that duplicates server-side validation to ease maintainability and provide a clear seperation of responsibility between client and server validation.
Change the Account Registration start endpoint to return the
AccountRegistrationIdand expiration data in the response body, simplifying the frontend and allowing central control of the expiration time.Add "is subdomain" check in the register page and illustrated messages for better user experience.
Checklist